Paginate results from server #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wk9874
reviewed
Mar 17, 2025
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paginate Server Response
Issue: #761
Python Version(s) Tested: 3.13
Operating System(s): Windows 11
Documentation PR: N/A
📝 Summary
Currently when making a
GETrequest to the server the user is able to ask for all results in one query, this means it can take some time to get a response because the server has to run a large database query. This is very inefficient for larger databases. This feature paginates the request.🔄 Changes
Add a middle function which turns a
GETrequest into a series of requests for 100 entries at a time incrementing thestartindex. This way the server is able to handle the request more quickly.✔️ Checklist